Fix documentation for callCC#132
Merged
hdgarrood merged 1 commit intopurescript:masterfrom Oct 15, 2020
Merged
Conversation
Fixed: `return` -> `pure` Added a type signature to `setTimeout`: If someone is trying to figure out what's going on here and they look up `setTimeout` on pursuit, they will find `setTimeout :: Int -> Effect Unit -> Effect TimeoutId` in `js-timers`, which does not work here at all. The added type signature shows we are intentionally using a simplified version of the function.
JordanMartinez
approved these changes
Oct 15, 2020
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed:
return->pureAdded a type signature to
setTimeout: If someone is trying to figure out what's going on here and they look upsetTimeouton pursuit, they will findsetTimeout :: Int -> Effect Unit -> Effect TimeoutIdinjs-timers, which does not work here at all. The added type signature shows we are intentionally using a simplified version of the function.