Use generic Marshal.SizeOf when possible (#21964) #24673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
85507b9 introduced a new call to Marshal.Sizeof(Type). This call is not AOT compatible, which is a regression as prior versions were AOT compatible, even if not directly supported. This conditionally uses the generic version of Marshal.SizeOf, which is AOT compatible to fix the issue. Closes #21824 Closes #21964 COPYBARA_INTEGRATE_REVIEW=#21964 from ThadHouse:genericsizeof a12294e PiperOrigin-RevId: 818694739
zhangskz
requested review from
PilgrimMemoirs and
jskeet
and removed request for
a team
mkruskal-google
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
85507b9 introduced a new call to Marshal.Sizeof(Type). This call is not AOT compatible, which is a regression as prior versions were AOT compatible, even if not directly supported.
This conditionally uses the generic version of Marshal.SizeOf, which is AOT compatible to fix the issue.
Closes #21824
Closes #21964
COPYBARA_INTEGRATE_REVIEW=#21964 from ThadHouse:genericsizeof a12294e PiperOrigin-RevId: 818694739
Cherry-pick of b9fc8a3