[prometheus-yet-another-cloudwatch-exporter] use configurable portName for service targetPort#7042
Merged
cristiangreco merged 1 commit intoJun 30, 2026
Conversation
…e for service targetPort The container port name is configurable via .Values.portName in the deployment, but the service hardcoded targetPort and name as "http". Setting portName to anything other than "http" broke the service -> pod port resolution. Use .Values.portName in the service so it stays in sync. Backward-compatible: portName defaults to "http". Signed-off-by: Amir Allahveran <amir.allahveran@grafana.com>
amir-allahveran
requested review from
andriikushch,
cristiangreco,
thomaspeitz and
tristanburgess
as code owners
cristiangreco
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
The container port name is configurable via
.Values.portNamein the deployment (templates/deployment.yaml), but the Service hardcoded bothtargetPortand the portnameashttp.Setting
portNameto anything other thanhttpbroke the Service → Pod port resolution, since the Service'stargetPort: httpno longer matched the container port name.This change makes the Service use
.Values.portNamefor bothtargetPortandname, keeping them in sync with the deployment.Backward compatibility
portNamedefaults tohttpinvalues.yaml, so existing installs render identically — no behavior change unless the user has overriddenportName.Checklist