feat: separate dockerfile to ease deployment #369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
descampsk
commented
Dec 15, 2025
|
|
||
| id: uuid.UUID = Field(primary_key=True, default_factory=uuid.uuid4) | ||
| content: str | ||
| content: str = Field(sa_column=Column(Text, nullable=False)) |
Author
There was a problem hiding this comment.
Issue with MYSQL external database and long content
descampsk
commented
Dec 15, 2025
| instructions: Optional[str] = Field(sa_column=Column(String), default=None) | ||
| tone: Optional[str] = Field(sa_column=Column(String), default=None) | ||
| verbosity: Optional[str] = Field(sa_column=Column(String), default=None) | ||
| instructions: Optional[str] = Field(sa_column=Column(Text), default=None) |
Author
There was a problem hiding this comment.
Issue with MYSQL external database and long content
descampsk
commented
Dec 15, 2025
| tone: Optional[str] = Field(sa_column=Column(String), default=None) | ||
| verbosity: Optional[str] = Field(sa_column=Column(String), default=None) | ||
| instructions: Optional[str] = Field(sa_column=Column(Text), default=None) | ||
| tone: Optional[str] = Field(sa_column=Column(String(128)), default=None) |
Author
There was a problem hiding this comment.
Issue with MYSQL external database. String without size is not accepted
descampsk
commented
Dec 15, 2025
| content: dict = Field(sa_column=Column(JSON)) | ||
| html_content: Optional[str] | ||
| speaker_note: Optional[str] = None | ||
| speaker_note: Optional[str] = Field(sa_column=Column(Text), default=None) |
Author
There was a problem hiding this comment.
Issue with MYSQL external database and long content
descampsk
commented
Dec 15, 2025
| uvicorn.run( | ||
| "api.main:app", | ||
| host="127.0.0.1", | ||
| host="0.0.0.0", |
Author
There was a problem hiding this comment.
Needed for the new docker compose and the deployment on Cloud Run
descampsk
commented
Dec 15, 2025
| @@ -0,0 +1,2 @@ | |||
| #!/bin/sh | |||
| exec npm run start -- -H 0.0.0.0 -p "$PORT" | |||
Author
There was a problem hiding this comment.
Needed for the new docker compose and the deployment on Cloud Run
descampsk
force-pushed
the
separate-dockerfile-to-ease-deployment
branch
from
d97daf4 to
e534bfd
Compare
descampsk
force-pushed
the
separate-dockerfile-to-ease-deployment
branch
from
e534bfd to
44ed4b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #368
This PR separates each servers into its own Dockerfile to ease the deployment in Cloud Provider solutions like Cloud Run.
It accelerate also the developpment by reducing the build size of each image.
It adds a new docker compose to use this new images.