-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
throw an error if there is more than 5000 slider marks #3350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - @ndrezn please have a look as well.
@chriddyp / @cleaaum is an error message here sufficient? I ask because in theory we expect an agent to respond to error messages and address them, so it will require an additional loop. The other options here are:
Ticks are auto generated if not explicitly provided, so could we expect to just leave this unspecified? See: https://dash.plotly.com/dash-core-components/slider#auto-generated-marks |
I think using the default settings could be useful (~5 ticks) with a warning message that its done that - makes it a little easier to use |
@cleaaum would you want generated code to always use the default, or do you want the library to switch to the 5-tick default if the requested number of ticks is too large? |
If I understand correctly, the main issue we want to resolve is that if the user supplies too many ticks to So we want to avoid the scenario where the Dash app is unresponsive (due to too many ticks). If that's correct, I think it would be reasonable for |
@gvwilson the latter: would want the library to switch to the 5-tick default if the requested number of ticks is too large. |
Let's go with that route and start with 500 ticks, which feels like a reasonable starting place. So:
Sound good? |
@T4rk1n Do you feel strongly that the substitution should happen in the frontend rather than the backend? (I don't feel strongly either way but my Python brain naturally thinks of Python implementations first.) |
resolve #3331