-
Notifications
You must be signed in to change notification settings - Fork 6k
domain: release server id by revoke etcd session #64192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: AmoebaProtozoa <8039876+AmoebaProtozoa@users.noreply.github.com>
|
Hi @AmoebaProtozoa. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #64192 +/- ##
================================================
+ Coverage 72.6828% 74.8469% +2.1640%
================================================
Files 1858 1881 +23
Lines 502725 510840 +8115
================================================
+ Hits 365395 382348 +16953
+ Misses 115087 104881 -10206
- Partials 22243 23611 +1368
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: disksing, hawkingrei The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/assign @wjhuang2016 |
What problem does this PR solve?
Issue Number: close #64191
Problem Summary:
What changed and how does it work?
change the way server id was released. Instead of deleting the etcd key directly, which may leak empty lease, close the serverID session instead.
Check List
Tests
tiup playground --db.binpath ./bin/tidb-servertiup playground --pid xxxRelease note
Please refer to Release Notes Language Style Guide to write a quality release note.