-
Notifications
You must be signed in to change notification settings - Fork 6k
session: fix rollback on killed txn may panic (#64001) #64185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-8.5
Are you sure you want to change the base?
session: fix rollback on killed txn may panic (#64001) #64185
Conversation
Signed-off-by: you06 <you1474600@gmail.com>
|
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #64185 +/- ##
================================================
Coverage ? 76.4642%
================================================
Files ? 1654
Lines ? 455804
Branches ? 0
================================================
Hits ? 348527
Misses ? 86181
Partials ? 21096
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
@ti-chi-bot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This is an automated cherry-pick of #64001
What problem does this PR solve?
Issue Number: close #63956
Problem Summary:
What changed and how does it work?
The memory tracker will raise an error when called for a terminated session, and tracking memory during the rollback phase is not a concern.
This PR resets the memory footprint hook to a no-op before rollback so killed sessions don’t touch a tracker belongs to a killed session.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.