-
Notifications
You must be signed in to change notification settings - Fork 6k
br: enhance version info logging, trim keyspace prefix for region merging #64178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: hillium <yu745514916@live.com>
Signed-off-by: hillium <yu745514916@live.com>
|
Hi @YuJuncen. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: hillium <yu745514916@live.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #64178 +/- ##
================================================
+ Coverage 72.6850% 74.7770% +2.0920%
================================================
Files 1858 1859 +1
Lines 502321 505643 +3322
================================================
+ Hits 365112 378105 +12993
+ Misses 114988 104605 -10383
- Partials 22221 22933 +712
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
| fmt.Fprintf(&buf, "Race Enabled: %t\n", israce.RaceEnabled) | ||
| kt := "Classic" | ||
| if kerneltype.IsNextGen() { | ||
| kt = "Next-Gen" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to check kernel type has a conflict with config --keyspace-name before backup and restore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TiKV itself supports ApiV2. I think it is reasonable to restore to a keyspace with TiKV.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use this flag to determine restore logic (e.g. download one peer/three peers)
is that ok using next-gen type br to restore ApiV2 classical tikv?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we'd better use kerneltype.IsNextGen to determine whether download to all peers.
Signed-off-by: Juncen Yu <yujuncen@pingcap.com>
|
/test pull-br-integration-test |
|
@YuJuncen: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: close #64195
Problem Summary:
br --versiondoesn't contain the kenrnel type though we are buildingNext GenBR in our pipeline. This can be confusing and error-prone.Also this PR trims keyspace prefix when merging small files.
What changed and how does it work?
Added
Kernel Typeto BR version.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.