Skip to content

sem, privilege: fix the issue that some privileges cannot be limited #64160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

sem, privilege: fix the issue that some privileges cannot be limited #64160

wants to merge 1 commit into from
+30 −6

Conversation

@YangKeao
Copy link
Member

What problem does this PR solve?

Issue Number: close #64159

Problem Summary:

What changed and how does it work?

  1. Turn the privilege into upper case before passing it to SEM.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 28, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign elsa0520 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@YangKeao
fix the issue that some privileges cannot be limited
69cb46e 
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
@YangKeao YangKeao requested review from hawkingrei and xhebox October 28, 2025 10:16
@codecov
Copy link

codecov bot commented Oct 28, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.4070%. Comparing base (bb0b895) to head (69cb46e).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #64160        +/-   ##
================================================
+ Coverage   72.6850%   73.4070%   +0.7220%     
================================================
  Files          1858       1859         +1     
  Lines        502321     502532       +211     
================================================
+ Hits         365112     368894      +3782     
+ Misses       114988     111586      -3402     
+ Partials      22221      22052       -169
Flag Coverage Δ
integration 41.9222% <0.0000%> (?)
unit 72.5422% <66.6666%> (+0.2939%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8700% <ø> (ø)
parser ∅ <ø> (∅)
br 46.3979% <ø> (+0.0354%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@YangKeao
Copy link
Member Author

/check-issue-triage-complete
lance6716
lance6716 reviewed Oct 28, 2025
View reviewed changes
pkg/planner/core/planbuilder.go
if semv2.IsEnabled() {
if (len(item.Name) > 0 && semv2.IsRestrictedPrivilege(item.Name)) ||
(len(item.Name) == 0 && semv2.IsRestrictedPrivilege(item.Priv.String())) {
if (len(item.Name) > 0 && semv2.IsRestrictedPrivilege(strings.ToUpper(item.Name))) ||
Copy link
Contributor

@lance6716 lance6716 Oct 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe inside IsRestrictedPrivilege add an intest assertion that make sure the argument is in uppercase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

2 participants

@YangKeao @lance6716