Skip to content

Fix: Tests throwing warnings #1374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Fix: Tests throwing warnings #1374

wants to merge 7 commits into from
+342 −357

Conversation

JimTools
Copy link
Contributor

@JimTools JimTools commented Jan 19, 2025 •
edited
Loading

Fixing tests that are throwing warnings and reducing noise in test output. has been done in three stages.

  • Fixing PHPUnit deprecation notices
  • Fixing language-level deprecation warnings
  • Updated mongodb/mongodb to fix language-level deprecation warnings
  • markingSnsQs as incomplete, as it's very flaky.
PHPUnit 9.6.23 by Sebastian Bergmann and contributors.

.............................................................   61 / 3135 (  1%)
.............................................................  122 / 3135 (  3%)
.............................................................  183 / 3135 (  5%)
.............................................................  244 / 3135 (  7%)
.............................................................  305 / 3135 (  9%)
.............................................................  366 / 3135 ( 11%)
.............................................................  427 / 3135 ( 13%)
.............................................................  488 / 3135 ( 15%)
.............................................................  549 / 3135 ( 17%)
.............................................................  610 / 3135 ( 19%)
.............................................................  671 / 3135 ( 21%)
.............................................................  732 / 3135 ( 23%)
.............................................................  793 / 3135 ( 25%)
.............................................................  854 / 3135 ( 27%)
.............................................................  915 / 3135 ( 29%)
.............................................................  976 / 3135 ( 31%)
............................................................. 1037 / 3135 ( 33%)
............................................................. 1098 / 3135 ( 35%)
............................................................. 1159 / 3135 ( 36%)
............................................................. 1220 / 3135 ( 38%)
............................................................. 1281 / 3135 ( 40%)
............................................................. 1342 / 3135 ( 42%)
.............................I............................... 1403 / 3135 ( 44%)
............................................................. 1464 / 3135 ( 46%)
................I............................................ 1525 / 3135 ( 48%)
............................................................. 1586 / 3135 ( 50%)
............................................................. 1647 / 3135 ( 52%)
............................................................. 1708 / 3135 ( 54%)
............................................................. 1769 / 3135 ( 56%)
............................................................. 1830 / 3135 ( 58%)
............................................................. 1891 / 3135 ( 60%)
............................................................. 1952 / 3135 ( 62%)
............................................................. 2013 / 3135 ( 64%)
............................................................. 2074 / 3135 ( 66%)
............................................................. 2135 / 3135 ( 68%)
............................................................. 2196 / 3135 ( 70%)
............................................................. 2257 / 3135 ( 71%)
............................................................. 2318 / 3135 ( 73%)
............................................................. 2379 / 3135 ( 75%)
........................................................%5|1746392420.682|CONFWARN|rdkafka#producer-1| [thrd:app]: No `bootstrap.servers` configured: client will not be able to connect to Kafka cluster
..... 2440 / 3135 ( 77%)
........................%4|1746392420.710|CONFWARN|rdkafka#producer-6| [thrd:app]: Configuration property group.id is a consumer property and will be ignored by this producer instance
%5|1746392420.710|CONFWARN|rdkafka#producer-6| [thrd:app]: No `bootstrap.servers` configured: client will not be able to connect to Kafka cluster
..........................%4|1746392420.730|CONFWARN|rdkafka#producer-8| [thrd:app]: Configuration property group.id is a consumer property and will be ignored by this producer instance
%4|1746392420.730|CONFWARN|rdkafka#producer-8| [thrd:app]: Configuration property enable.auto.commit is a consumer property and will be ignored by this producer instance
%4|1746392420.730|CONFWARN|rdkafka#producer-8| [thrd:app]: Configuration property auto.offset.reset is a consumer property and will be ignored by this producer instance
........... 2501 / 3135 ( 79%)
............................................................. 2562 / 3135 ( 81%)
............................................................. 2623 / 3135 ( 83%)
............................................................. 2684 / 3135 ( 85%)
............................................................. 2745 / 3135 ( 87%)
............................................................. 2806 / 3135 ( 89%)
............................................................. 2867 / 3135 ( 91%)
............................................................. 2928 / 3135 ( 93%)
............................................................. 2989 / 3135 ( 95%)
............................................................. 3050 / 3135 ( 97%)
............................................................. 3111 / 3135 ( 99%)
.....................I..                                      3135 / 3135 (100%)

Time: 02:27.999, Memory: 132.50 MB

OK, but incomplete, skipped, or risky tests!
Tests: 3135, Assertions: 6482, Incomplete: 3.
@JimTools JimTools force-pushed the bugfix/test-warnings branch from 190ac7c to ad5153f Compare January 19, 2025 20:50
@JimTools JimTools force-pushed the bugfix/test-warnings branch 2 times, most recently from e70de43 to 13e0fd0 Compare April 19, 2025 10:32
JimTools added 4 commits May 3, 2025 11:01
@JimTools
fix: fixing unit test warnings
83f97d3 
fixing unit test warnings that are throwing deprecation errors for PHPUnit 10
@JimTools
fix: Fixed language level deprecations
6adc0cd
@JimTools
chore: running php-cs-fixer
b8560da
@JimTools
fix: Adding patch version to phpunit
52bd77d 
Adding a patch number to phpunit so the test suite is always using the highest
version of phpunit
@JimTools JimTools force-pushed the bugfix/test-warnings branch from 13e0fd0 to 52bd77d Compare May 3, 2025 10:19
JimTools added 2 commits May 3, 2025 12:14
@JimTools
chore: bumping phpunit version
9aba323 
bumping phpunit version to fix issues with --prefer-lowest and
`assertObjectHasProperty` looks like this was added in phpunit 9.6.x
at some point in time.

sebastianbergmann/phpunit#5220
@JimTools
fix: aliging symfony versions
21cb438 
Aliging symfony version unit tests with the feature tests
@JimTools JimTools force-pushed the bugfix/test-warnings branch from 90d2cff to 21cb438 Compare May 4, 2025 20:24
JimTools
JimTools commented May 4, 2025
View reviewed changes
pkg/snsqs/Tests/Spec/SnsQsSendToTopicAndReceiveNoWaitFromQueueTest.php
@@ -23,6 +23,11 @@ protected function tearDown(): void
$this->cleanUpSnsQs();
}

public function test()
{
$this->markTestIncomplete('flaky need to look into queue-spec');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test seems to be very flaky, constantly failing.

1) Enqueue\SnsQs\Tests\Spec\SnsQsSendToTopicAndReceiveNoWaitFromQueueTest::test
Failed asserting that null is an instance of interface "Interop\Queue\Message".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant
@JimTools