Repository navigation
Remove old multi_match view - #125
Merged
Merged
Conversation
orangejulius
force-pushed
the
remove-old-multi_match
branch
from
August 26, 2020 18:24
ebdc5ae to
cad3b72
Compare
BREAKING CHANGE: the old multi_match view is removed. I don't remember writing it, but since #14 in early 2016(!) we have had a general purpose view for [multi_match](https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-multi-match-query.html) queries. This view doesn't fit our current pattern for keeping general purpose (i.e. corresponding to built in Elasticsearch query) views in the `view/leaf` directory, and it doesn't support as much functionality as the `multi_match` view @Joxit made for us in #114 last year. This PR removes the older view, and in the process converts the `admin_multi_match` view over to using the new `multi_match` leaf query. While I don't think anything in the Pelias API uses the old `multi_match` query directly, this removal will require changes to the API tests because of minor differences in the final output.
orangejulius
force-pushed
the
remove-old-multi_match
branch
from
August 26, 2020 18:43
cad3b72 to
ae426ae
Compare
Member
Author
|
Just to be sure, before merging this we ran it on a split test on Geocode Earth and did not see any performance regressions. Elasticsearch claims that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't remember writing it, but since #14 in early 2016(!) we have had a general purpose view for multi_match queries.
This view doesn't fit our current pattern for keeping general purpose (i.e. corresponding to built in Elasticsearch query) views in the
view/leafdirectory, and it doesn't support as much functionality as themulti_matchview @Joxit made for us in #114 last year.This PR removes the older view, and in the process converts the
admin_multi_matchview over to using the newmulti_matchleaf query.While I don't think anything in the Pelias API uses the old
multi_matchquery directly, this removal will require changes to theAPI tests because of two minor differences in the final output:
cutoff_frequencyis removed. This would have been possible to keep, but withcutoff_frequencybeing redundant in ES7+, it's not worth the efforttypeis a required parameter of the newmulti_matchleaf query. This is because thetypeis used by the view to determine what other parameters are allowed.