Conversation
mbrodala
left a comment
mbrodala
left a comment
There was a problem hiding this comment.
Can you temporarily adjust on so that this runs in the context of this MR? Of course, no actual upload should happen so maybe use echo composer ... in the scripts.
.github/workflows/ci.yml
Outdated
| - name: Get version | ||
| id: get-version | ||
| run: echo "version=${GITHUB_REF/refs\/tags\//}" >> $GITHUB_ENV | ||
| run: echo "version=${{ github.event.release.tag_name }}" >> $GITHUB_ENV |
There was a problem hiding this comment.
This step can be dropped, we can directly pass github.event.release.tag_name as TAG in the next step.
| "echo \"require 'phar://' . \\TYPO3\\CMS\\Core\\Utility\\ExtensionManagementUtility::extPath('$(composer config extra.typo3/cms.extension-key)') . 'vendors.phar/vendor/autoload.php';\" >> ext_localconf.php", | ||
| "composer global exec -v -- tailor set-version $TAG", | ||
| "composer global exec -v -- tailor ter:publish --comment \"$(git tag -l --format='%(contents)' $TAG)\" $TAG" | ||
| "composer global exec -v -- tailor ter:publish --comment \"${UPLOAD_MESSAGE}\" $TAG" |
There was a problem hiding this comment.
We don't need to further take care of quoting here? This is a possibly large multi-line string after all.
There was a problem hiding this comment.
I was thinking the same. But I have no idea if it is necessary or not.
|
The problem is that the release variable only exists in a release context. Making testing difficult |
|
Just saw this which would be a much simpler solution and improve the current state: So basically something like this: |
|
Just did that, let me know if this works for you: #222 |
2 participants
No description provided.