Your search did not match any code when using a language filter from page 2 where there are visible hits

[jsoref]

Select Topic Area

Bug

Body

Problem

Sub-searches result in error messages claiming there are no hits when additional filters are added while viewing a later page number because the cursor is retained even though the result set has fewer pages than the page the user is viewing when they add their filter.

Steps

1. Visit https://github.com/search?q=repo%3Adotnet%2Fruntime+RegexMatchTimeoutException&type=code&p=2
   

2. Click C# on the left under Languages
   

   Your search did not match any code
   However we found 12 issues and 3 pull requests that matched your search query. Alternatively try one of the tips below.

Notes

This is actually a hard problem to solve. The worst thing to do is to lie to the user and say there were no matches.

Ideally

Ideally you'd imagine the current search results as a "cursor" and see if any of the search results are matched by the new filter and then go to the page that has the matched search results.

If there are no matches on the current page, you should imagine the last search result before the current page and the first search result after the current page and take the user to the page that has that first search result from after the current page.

The goal of searching and filtering is to say:

• I've seen this stuff, I've decided I want to see things like "x".
• I've seen this stuff, I've decided I don't want to see things like "y".

In either case, things the user has already seen are not necessarily interesting, but they do want to see what they're looking at with a focus on what they want to see or without what they don't want to see. They don't want to be shown nothing. I certainly don't. And I do filter (both positive and negative) searches like this all the time.

Simple case

In this case, there is only one page of filtered search results:
https://github.com/search?q=repo%3Adotnet%2Fruntime+RegexMatchTimeoutException+language%3AC%23&type=code&l=C%23

Painful case

1. I'm on page 10 of the search results.
2. And every second result is a result I don't care about (e.g. C# vs XML).
3. There are 19 pages total.
4. If I click C# with the current behavior, I'm taken to page 10/9 and shown an error message.
5. Ideally, I'm taken to page 5 with the results I'm looking at plus a bunch of results from what would be page 11/19 in the unfiltered view.
6. I can then continue reading where I left off without having to start from page 1/9 all over until I get back to page 5/9 which is where I was before I filtered.

[github-actions[bot]]

💬 Your Product Feedback Has Been Submitted 🎉

Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users.

Here's what you can expect moving forward ⏩

• Your input will be carefully reviewed and cataloged by members of our product teams. 
  • Due to the high volume of submissions, we may not always be able to provide individual responses.
  • Rest assured, your feedback will help chart our course for product improvements.
• Other users may engage with your post, sharing their own perspectives or experiences. 
• GitHub staff may reach out for further clarification or insight. 
  • We may 'Answer' your discussion if there is a current solution, workaround, or roadmap/changelog post related to the feedback.

Where to look to see what's shipping 👀

• Read the Changelog for real-time updates on the latest GitHub features, enhancements, and calls for feedback.
• Explore our Product Roadmap, which details upcoming major releases and initiatives.

What you can do in the meantime 💻

• Upvote and comment on other user feedback Discussions that resonate with you.
• Add more information at any point! Useful details include: use cases, relevant labels, desired outcomes, and any accompanying screenshots.

As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities.

Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐