Skip to content

Conversation

@bupd
Copy link
Contributor

@bupd bupd commented Dec 7, 2025

What this PR does / why we need it

  • Enable linter revive
  • fix lint issues
  • fix antipatterns

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1915

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?
@codecov
Copy link

codecov bot commented Dec 7, 2025

Codecov Report

❌ Patch coverage is 90.83333% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.14%. Comparing base (992543e) to head (d48db9e).

Files with missing lines Patch % Lines
internal/mock/repository.go 0.00% 9 Missing ⚠️
cmd/oras/internal/display/metadata/discard.go 0.00% 1 Missing ⚠️
internal/contentutil/target.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1925      +/-   ##
==========================================
- Coverage   87.22%   87.14%   -0.08%     
==========================================
  Files         143      143              
  Lines        5540     5539       -1     
==========================================
- Hits         4832     4827       -5     
- Misses        421      425       +4     
  Partials      287      287              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@TerryHowe
Copy link
Member

Looks like those errors should be ignored.

@bupd
Copy link
Contributor Author

bupd commented Dec 17, 2025

@TerryHowe ready to be merged. Thanks for the heads up.

@TerryHowe
Copy link
Member

Looks like a conflict in target_test.go

@FeynmanZhou
Copy link
Member

@bupd Can you pls resolve the conflict?

bupd added 7 commits January 7, 2026 01:53
- this is a first commit of these changes

Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: bupd <bupdprasanth@gmail.com>
@bupd
Copy link
Contributor Author

bupd commented Jan 6, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants