-
Notifications
You must be signed in to change notification settings - Fork 221
chore: add revive and fix lint errors #1925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1925 +/- ##
==========================================
- Coverage 87.22% 87.14% -0.08%
==========================================
Files 143 143
Lines 5540 5539 -1
==========================================
- Hits 4832 4827 -5
- Misses 421 425 +4
Partials 287 287 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Looks like those errors should be ignored. |
|
@TerryHowe ready to be merged. Thanks for the heads up. |
|
Looks like a conflict in target_test.go |
|
@bupd Can you pls resolve the conflict? |
- this is a first commit of these changes Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: bupd <bupdprasanth@gmail.com>
|
@FeynmanZhou done |
What this PR does / why we need it
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1915
Please check the following list: