Skip to content

Conversation

@jefferyto
Copy link
Member

Maintainer: me
Compile tested: armsr-armv7, 2023-08-13 snapshot sdk
Run tested: armsr-armv7 (qemu), 2023-08-13 snapshot

Description:
Upstream has updated the Go compiler to not use gold when building for arm, and is waiting for a fix to binutils (released in 2.41) before doing the same for aarch64. (upstream issue)

Based on the above, it does not appear that golang/go#49748 will be merged. This removes the patch from that pull request.

Upstream has updated the Go compiler to not use gold when building for
arm, and is waiting for a fix to binutils (released in 2.41) before
doing the same for aarch64.[1]

Based on the above, it does not appear that
golang/go#49748 will be merged. This removes the
patch from that pull request.

[1]: golang/go#22040

Signed-off-by: Jeffery To <jeffery.to@gmail.com>
@BKPepe BKPepe merged commit d9686cc into openwrt:master Aug 15, 2023
@jefferyto jefferyto deleted the golang-1.21.0 branch August 16, 2023 02:49
@hnyman
Copy link
Contributor

hnyman commented Aug 19, 2023

This seems to have broken lots of go packages, especially those that use quic. e.g. adguardhome
E.g. https://downloads.openwrt.org/snapshots/faillogs/aarch64_cortex-a72/packages/

./../../../../dl/go-mod-cache/github.com/quic-go/quic-go@v0.35.1/internal/qtls/go121.go:5:13: cannot use "The version of quic-go you're using can't be built on Go 1.21 yet. For more details, please see https://github.com/quic-go/quic-go/wiki/quic-go-and-Go-versions." (untyped string constant "The version of quic-go you're using can't be built on Go 1.21 yet. F...) as int value in variable declaration

@jefferyto
Copy link
Member Author

This seems to have broken lots of go packages,

Yes, this is why 23.05 hasn't been updated yet.

especially those that use quic.

A Go 1.21-compatible version of quic-go has already been released (v0.37.4). It's up to each Go program/package to update their own dependencies.

In general, every major Go update causes these packages to fail to build for this same exact reason, i.e. quic-go has to be updated, then each Go program has to update their dependencies. I don't see a point in waiting for most/all Go programs to be updated first.

@hnyman
Copy link
Contributor

hnyman commented Aug 19, 2023

Yeah, apparently AdGuard Home v0.107.36 is needed for go 1.21 compatibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants