Repository navigation
Commit package-lock.json and install from it in CI - #1
Merged
Merged
Conversation
package-lock.json was gitignored, so every CI run and every contributor resolved dependencies fresh with npm install, and nothing recorded what a passing build actually installed. Committing it makes installs reproducible, lets npm ci verify every tarball's integrity hash, and gives Dependabot and the org's lockfile check something to work on. The lockfile workflow fails when the lockfile doesn't regenerate unchanged or resolves anything outside the npm registry. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
package-lock.jsonis committed instead of gitignored, CI installs withnpm ci, and alockfileworkflow checks it on every pull request. The org's repository standards ask every JavaScript repository to commit its lockfile. Without one, each install resolves fresh, so nothing records what a passing build installed andnpm cican't verify integrity hashes.The lockfile is a fresh resolve within the existing ranges, the same versions a clean
npm installwould get today.Locally on Node 24.20 / npm 11.19:
npm run buildand all 94 tests pass.🤖 Generated with Claude Code