8358319: Pem.decode should cache the Pattern

[shipilev]

SonarCloud complains we are using the String.replaceAll() method that creates Pattern internally every time. This looks a minor inefficiency in preview feature, but we can fix it from the day 1. Also fixed the variable name style in adjacent cached Pattern.

Additional testing:

• Linux x86_64 server fastdebug, jdk_security

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8358319: Pem.decode should cache the Pattern (Enhancement - P4)

Reviewers

• Anthony Scarpino (@ascarpino - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25583/head:pull/25583
$ git checkout pull/25583

Update a local copy of the PR:
$ git checkout pull/25583
$ git pull https://git.openjdk.org/jdk.git pull/25583/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25583

View PR using the GUI difftool:
$ git pr show -t 25583

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25583.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358319: Pem.decode should cache the Pattern

Reviewed-by: ascarpino

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

• bce2bd2: 8356308: Assert with -Xlog:class+path when classpath has an empty element
• 8b6a11f: 8352187: Don't start management agent during AOT cache creation
• ab5de45: 8357991: make bootcycle-images is broken after JDK-8349665
• ... and 9 more: https://git.openjdk.org/jdk/compare/eb9badd8a4ea6dca834525fd49429e2ce771a76c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (bbdb5b00)

[ascarpino]

looks good

[shipilev]

looks good

Thanks! A bit blurry on review rules in this area: do you want me to wait for someone else to review? More tests to run?

[ascarpino]

Tests passed

[shipilev]

Thanks! I'll integrate once my day starts tomorrow.

[shipilev]

Here goes.

/integrate

[openjdk]

Going to push as commit 6f783e5.
Since your change was applied there have been 27 commits pushed to the master branch:

• cff75eb: 8358316: PKCS8Key.getEncoded() can throw NPE after JDK-8298420
• be923a8: 8353266: C2: Wrong execution with Integer.bitCount(int) intrinsic on AArch64
• dbf562c: 8358313: G1: Refactor G1CollectedHeap::is_maximal_no_gc
• ... and 24 more: https://git.openjdk.org/jdk/compare/eb9badd8a4ea6dca834525fd49429e2ce771a76c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 6f783e5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.