Skip to content

8358294: Remove unnecessary GenAlignment #25577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

8358294: Remove unnecessary GenAlignment #25577

wants to merge 1 commit into from
+59 −105

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Jun 2, 2025 •
edited by openjdk bot
Loading

Simple replacement of GenAlignment with SpaceAlignment, because they always have the same value. Removing the former to reduce complexity.

Test: tier1-3

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8358294: Remove unnecessary GenAlignment (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25577/head:pull/25577
$ git checkout pull/25577

Update a local copy of the PR:
$ git checkout pull/25577
$ git pull https://git.openjdk.org/jdk.git pull/25577/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25577

View PR using the GUI difftool:
$ git pr show -t 25577

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25577.diff

Using Webrev

Link to Webrev Comment
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 2, 2025

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
@openjdk
Copy link

openjdk bot commented Jun 2, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.
@openjdk openjdk bot changed the title 8358294 Jun 2, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 2, 2025
@openjdk
Copy link

openjdk bot commented Jun 2, 2025

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.
@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Jun 2, 2025
@albertnetymk
Copy link
Member Author

/cc hospot-gc
@mlbridge
Copy link

mlbridge bot commented Jun 2, 2025

Webrevs
@openjdk
Copy link

openjdk bot commented Jun 2, 2025

@albertnetymk
The label hospot-gc is not a valid label.
These labels are valid:

  • graal
  • serviceability
  • hotspot
  • hotspot-compiler
  • ide-support
  • kulla
  • i18n
  • shenandoah
  • jdk
  • javadoc
  • security
  • hotspot-runtime
  • jmx
  • build
  • nio
  • client
  • core-libs
  • compiler
  • net
  • hotspot-gc
  • hotspot-jfr
@albertnetymk
Copy link
Member Author

/cc hotspot-gc
@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Jun 2, 2025
@openjdk
Copy link

openjdk bot commented Jun 2, 2025

@albertnetymk
The hotspot-gc label was successfully added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org hotspot-gc hotspot-gc-dev@openjdk.org rfr Pull request is ready for review
1 participant
@albertnetymk