-
Notifications
You must be signed in to change notification settings - Fork 5.9k
8358217: jdk/incubator/vector/PreferredSpeciesTest.java#id0 failures - expected [128] but found [256] #25565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back igraves! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@igraves To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
The original test made an incorrect assumption about *MaxVector sizes that doesn't hold across every platform. The assertion based on this is now removed. |
@igraves Syntax:
User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address. |
@igraves Syntax:
User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address. |
/contributor add @PaulSandoz |
/contributor add @jaikiran |
/label core-libs |
@igraves |
@igraves |
@igraves |
@igraves this pull request can not be integrated into git checkout JDK-8358217
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
Removing incorrect assumptions and assertions from a breaking test related to https://bugs.openjdk.org/browse/JDK-8358218
Progress
Issue
Reviewers
Contributors
<psandoz@openjdk.org>
<jpai@openjdk.org>
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25565/head:pull/25565
$ git checkout pull/25565
Update a local copy of the PR:
$ git checkout pull/25565
$ git pull https://git.openjdk.org/jdk.git pull/25565/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25565
View PR using the GUI difftool:
$ git pr show -t 25565
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25565.diff
Using Webrev
Link to Webrev Comment