Skip to content

8358217: jdk/incubator/vector/PreferredSpeciesTest.java#id0 failures - expected [128] but found [256] #25565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

igraves
Copy link
Member

@igraves igraves commented May 31, 2025

Removing incorrect assumptions and assertions from a breaking test related to https://bugs.openjdk.org/browse/JDK-8358218


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8358217: jdk/incubator/vector/PreferredSpeciesTest.java#id0 failures - expected [128] but found [256] (Bug - P4)

Reviewers

Contributors

  • Paul Sandoz <psandoz@openjdk.org>
  • Jaikiran Pai <jpai@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25565/head:pull/25565
$ git checkout pull/25565

Update a local copy of the PR:
$ git checkout pull/25565
$ git pull https://git.openjdk.org/jdk.git pull/25565/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25565

View PR using the GUI difftool:
$ git pr show -t 25565

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25565.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 31, 2025

👋 Welcome back igraves! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 31, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 31, 2025
@openjdk
Copy link

openjdk bot commented May 31, 2025

@igraves To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah
@igraves
Copy link
Member Author

igraves commented May 31, 2025

The original test made an incorrect assumption about *MaxVector sizes that doesn't hold across every platform. The assertion based on this is now removed.

@openjdk
Copy link

openjdk bot commented May 31, 2025

@igraves Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

  • /contributor add @openjdk-bot
  • /contributor add duke
  • /contributor add J. Duke <duke@openjdk.org>

User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address.

@openjdk
Copy link

openjdk bot commented May 31, 2025

@igraves Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

  • /contributor add @openjdk-bot
  • /contributor add duke
  • /contributor add J. Duke <duke@openjdk.org>

User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address.

@igraves
Copy link
Member Author

igraves commented May 31, 2025

/contributor add @PaulSandoz

@igraves
Copy link
Member Author

igraves commented May 31, 2025

/contributor add @jaikiran

@igraves
Copy link
Member Author

igraves commented May 31, 2025

/label core-libs

@openjdk
Copy link

openjdk bot commented May 31, 2025

@igraves
Contributor Paul Sandoz <psandoz@openjdk.org> successfully added.

@openjdk
Copy link

openjdk bot commented May 31, 2025

@igraves
Contributor Jaikiran Pai <jpai@openjdk.org> successfully added.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label May 31, 2025
@openjdk
Copy link

openjdk bot commented May 31, 2025

@igraves
The core-libs label was successfully added.

@mlbridge
Copy link

mlbridge bot commented May 31, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented May 31, 2025

@igraves this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JDK-8358217
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push
@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label May 31, 2025
@openjdk openjdk bot removed the merge-conflict Pull request has merge conflict with target branch label May 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org rfr Pull request is ready for review
2 participants