8352187: Don't start management agent during AOT cache creation

[calvinccheung]

If a management agent is specified when creating an AOT cache, it resulted in java.lang.IllegalArgumentException.
To avoid the exception, this fix is not to start the management agent when creating an AOT cache.

Passed tiers 1 - 4 testing.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8352187: Don't start management agent during AOT cache creation (Bug - P3)

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer) Review applies to abeb7b6f
• Aleksey Shipilev (@shipilev - Reviewer)
• Ioi Lam (@iklam - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25562/head:pull/25562
$ git checkout pull/25562

Update a local copy of the PR:
$ git checkout pull/25562
$ git pull https://git.openjdk.org/jdk.git pull/25562/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25562

View PR using the GUI difftool:
$ git pr show -t 25562

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25562.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@calvinccheung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352187: Don't start management agent during AOT cache creation

Reviewed-by: shade, iklam, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 118 new commits pushed to the master branch:

• 1b6ae20: 8357576: FieldInfo::_index is not initialized by the constructor
• daab7b5: 8357796: Stylesheet adjustments after JDK-8357452
• a4eb151: 8357672: Extreme font sizes can cause font substitution
• ... and 115 more: https://git.openjdk.org/jdk/compare/c1f066e17eacf7649df4042e2fb985da9724ef40...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@calvinccheung The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (e694a720)
• 00: Full (abeb7b6f)

[vnkozlov]

Good.

[calvinccheung]

After discussion with Ioi offline, I've move the new test to a new file aotCache/ManagementAgent.java.

[iklam]

LGTM

[calvinccheung]

Thank you @vnkozlov @shipilev @iklam

/integrate

[openjdk]

Going to push as commit 8b6a11f.
Since your change was applied there have been 120 commits pushed to the master branch:

• ab5de45: 8357991: make bootcycle-images is broken after JDK-8349665
• 99a4b22: 8358102: GenShen: Age tables could be seeded with cumulative values
• 1b6ae20: 8357576: FieldInfo::_index is not initialized by the constructor
• ... and 117 more: https://git.openjdk.org/jdk/compare/c1f066e17eacf7649df4042e2fb985da9724ef40...master

Your commit was automatically rebased without conflicts.

[openjdk]

@calvinccheung Pushed as commit 8b6a11f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[AlanBateman]

this fix is not to start the management agent when creating an AOT cache.

I think this is good. The initial processing of -Dcom.sun.management will add the jdk.management.agent module to the root set so the set of modules when creating the AOT cache will be the same as runtime, even through the JMX agent isn't started.