8356803: Test TextLayout/TestControls fails on windows & linux: line and paragraph separator show non-zero advance

[gredler]

Per discussion in JBS, adds the following chars to the list of ignorable whitespace chars: U+000B (Vertical Tab), U+000C (Form Feed), U+0085 (Next Line), U+2028 (Line Separator), U+2029 (Paragraph Separator).

Adds the necessary testing in pre-existing automated test class test/jdk/java/awt/font/TextLayout/FormatCharAdvanceTest.java.

Removes now-unnecessary manual test test/jdk/java/awt/font/TextLayout/TestControls.java.

The test/jdk/java/awt/font, test/jdk/java/awt/print and test/jdk/java/awt/Graphics2D/DrawString tests all pass for me locally on Windows, Linux and macOS.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issues

• JDK-8356803: Test TextLayout/TestControls fails on windows & linux: line and paragraph separator show non-zero advance (Bug - P3)
• JDK-8356812: Create an automated version of TextLayout/TestControls (Enhancement - P4)

Reviewers

• Phil Race (@prrace - Reviewer)
• Harshitha Onkar (@honkar-jdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25560/head:pull/25560
$ git checkout pull/25560

Update a local copy of the PR:
$ git checkout pull/25560
$ git pull https://git.openjdk.org/jdk.git pull/25560/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25560

View PR using the GUI difftool:
$ git pr show -t 25560

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25560.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dgredler! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@gredler This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8356803: Test TextLayout/TestControls fails on windows & linux: line and paragraph separator show non-zero advance
8356812: Create an automated version of TextLayout/TestControls

Reviewed-by: prr, honkar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 88 new commits pushed to the master branch:

• da49fa5: 8354460: Streaming output for attach API should be turned on by default
• 704b599: 8358534: Bailout in Conv2B::Ideal when type of cmp input is not supported
• e235b61: 8357987: [JVMCI] Add support for retrieving all methods of a ResolvedJavaType
• ... and 85 more: https://git.openjdk.org/jdk/compare/94039e22bbe943888e858d8ae278145e2668526a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prrace, @honkar-jdk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@gredler The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[gredler]

/issue add JDK-8356812

[openjdk]

@gredler
Adding additional issue to issue list: 8356812: Create an automated version of TextLayout/TestControls.

[mlbridge]

Webrevs

• 00: Full (0b91df64)

[prrace]

looks good. automated tests all pass.

[honkar-jdk]

Tested the fix. It looks good to me.

Not sure of the reason behind @aivanov-jdk suggestion in JDK-8356812 to keep the manual test alongside the automated test.

I'm okay with deleting the manual test since the automated one covers all the cases.

[gredler]

@aivanov-jdk Let me know if there are any concerns on your end. Otherwise, I plan to mark as ready for integration later today. As @honkar-jdk mentioned, the automated test is checking much more than the manual test was (and won't bitrot as easily), so I don't think there's a reason to keep the manual test around.

[gredler]

/integrate

[openjdk]

@gredler
Your change (at version 0b91df6) is now ready to be sponsored by a Committer.

[honkar-jdk]

/sponsor

[openjdk]

Going to push as commit 9397535.
Since your change was applied there have been 88 commits pushed to the master branch:

• da49fa5: 8354460: Streaming output for attach API should be turned on by default
• 704b599: 8358534: Bailout in Conv2B::Ideal when type of cmp input is not supported
• e235b61: 8357987: [JVMCI] Add support for retrieving all methods of a ResolvedJavaType
• ... and 85 more: https://git.openjdk.org/jdk/compare/94039e22bbe943888e858d8ae278145e2668526a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@honkar-jdk @gredler Pushed as commit 9397535.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.