Skip to content

[codex] Close tail client on repair-loop exits#110

Merged
steipete merged 1 commit into
mainfrom
codex/close-tail-client-on-repair-exit
Jun 30, 2026
Merged

[codex] Close tail client on repair-loop exits#110
steipete merged 1 commit into
mainfrom
codex/close-tail-client-on-repair-exit

Conversation

@steipete

Copy link
Copy Markdown
Collaborator

Summary

  • close repair-loop tail clients on every RunTail exit path
  • keep the existing cancellation close path to unblock Tail, guarded with sync.Once
  • fixes the race where Tail could return through errCh after cancellation and skip Close

Validation

  • GOWORK=off go test -count=20 -race ./internal/syncer -run TestRunTailWithRepairLoopJoinsTailOnCancellation
  • GOWORK=off go test -count=1 -race ./internal/syncer
  • GOWORK=off go test -count=1 ./...

Context: main CI failed after the actions/cache dependency merge on the existing race-detector test TestRunTailWithRepairLoopJoinsTailOnCancellation.

@clawsweeper

clawsweeper Bot commented Jun 30, 2026

Copy link
Copy Markdown

ClawSweeper status: review started.

I am starting a fresh review of this pull request: [codex] Close tail client on repair-loop exits This is item 1/1 in the current shard. Shard 0/1.

This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking.

Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted.

@steipete steipete marked this pull request as ready for review June 30, 2026 23:47
@steipete steipete merged commit d041cbc into main Jun 30, 2026
10 checks passed
@steipete steipete deleted the codex/close-tail-client-on-repair-exit branch June 30, 2026 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant