Repository navigation
Conversation
main() read S3_PREFIX but walked the bucket from the top, so the reuploader sent every object in the failed-reports bucket and deleted each one fastpath accepted. Fastpath accepts any body, so that included objects that aren't measurements. Walk from S3_PREFIX and skip keys that don't end in .post. Fix the variable names in the Dockerfile and README (S3_BUCKET_NAME, S3_PREFIX), and the Dockerfile's AWS_REGION line, whose spaces around "=" made it part of the value. Add tests and a workflow to run them.
LDiazN
reviewed
Oct 21, 2026
| echo '[{"name":"${ECS_CONTAINER_NAME}","imageUri":"${IMAGE_NAME}:${BUILD_LABEL}"}]' > imagedefinitions.json | ||
|
|
||
| test: | ||
| pip install -q . pytest |
Contributor
There was a problem hiding this comment.
why not implementing the test command like other commands in backend? With hatch, see
backend/ooniapi/services/ooniprobe/Makefile
Lines 46 to 48 in f02b3f5
Contributor
There was a problem hiding this comment.
And also you're potentially installing pytest globally instead of inside a virtualenv, hatch helps with this.
It would also be nice to add test as a .PHONY target
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use S3_PREFIX so that the failed-reports bucket can hold a dedup key (alongside postcans), for reprocessing of measurements that got doubly processed by resubmitting into fastpath. fixes the previously ignored S3_PREFIX and adds a test to confirm it behaves as expected. Skip keys that don't end in .post.
Fix the variable names in the Dockerfile and README (S3_BUCKET_NAME, S3_PREFIX), and the Dockerfile's AWS_REGION line, whose spaces around "=" made it part of the value.