Repository navigation
Conversation
Merge the GET endpoints of oonimeasurements and oonifindings into one document, dropping ops endpoints and the private /api/_/ ones, keeping only the schemas those paths reach, and setting servers to https://api.ooni.io. The merge fails if two services serve the same path or define one schema differently. CI uploads the result as the openapi artifact and warns when it differs from what https://api.ooni.io/openapi.json serves, so a stale copy shows up as a warning instead of drifting silently. Today it is 15 paths and 32 schemas, 69 KB.
GitHub lists artifacts only at the bottom of the run page, not on the PR, so put a direct download link in the summary.
upload-artifact v7 can upload a single file without archiving it, so the summary link downloads openapi.json itself instead of a zip.
The job summary only shows on the run's summary page, which the PR's checks do not link to; annotations show there as well.
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (93.25%) is below the target coverage (95.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #1291 +/- ##
==========================================
- Coverage 98.17% 93.25% -4.93%
==========================================
Files 20 84 +64
Lines 2084 8834 +6750
Branches 82 516 +434
==========================================
+ Hits 2046 8238 +6192
- Misses 32 491 +459
- Partials 6 105 +99
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
q: do we actually want to expose the private api routes? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge the GET endpoints of oonimeasurements and oonifindings into one document, dropping ops endpoints and the private /api/_/ ones, keeping only the schemas those paths reach, and setting servers to https://api.ooni.io. The merge fails if two services serve the same path or define one schema differently.
CI uploads the result as the openapi artifact and warns when it differs from what https://api.ooni.io/openapi.json serves, so a stale copy shows up as a warning instead of drifting silently. Today it is 15 paths and 32 schemas, 69 KB.