Repository navigation
Fix torsf stats - #1261
Open
aagbsn wants to merge 3 commits into
Open
Fix torsf stats#1261aagbsn wants to merge 3 commits into
aagbsn wants to merge 3 commits into
Conversation
LDiazN
reviewed
Oct 21, 2026
| def test_torsf_stats_group_by_probe_cc(client, torsf_fastpath_rows): | ||
| params = {"since": "2019-02-28", "until": "2019-03-03"} | ||
| response = client.get("/api/v1/torsf_stats", params=params) | ||
| assert response.status_code == 200, response.text |
Contributor
There was a problem hiding this comment.
Let's use the getj function for this test:
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in the legacy api probe_cc was optional, but the ported method did not allow a None value. This adds a test to demonstrate the failure and the fix is to give probe_cc a default value. measurement_count was also missing in the response.