fix: userAgent error on CF #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Deploying dashboard-w1c0 with
|
| Latest commit: |
516f2f6
|
| Status: | ⚡️ Build in progress... |
benjamincanac
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6
It is not related to
createSharedComposablebut from Unovis used in https://github.com/nuxt-ui-pro/dashboard/blob/main/components/home/HomeChart.vue#L3Unovis uses a polyfill for the resize observer: https://github.com/f5/unovis/blob/af5f4e44c9bd534b69462801b85a5d40a68d6493/packages/ts/src/utils/resize-observer.ts#L2
As it ResizeObserver does not exists on edge environment and because we cannot have external in a worker, it adds the polyfill with the IIFE format which is wrongly transformed to:
See source
The only quick solution I found is to split the HomeChart component for now, best would be to have a Chart component for it using Unoviz in the future or in this PR (I let @benjamincanac decides for it)