fix: prerelease identifier starting with digits #781
Merged
+62
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Looks like the lint errors are related to template, not this change |
Member
|
Thanks, good move using the |
wraithgar
approved these changes
May 8, 2025
Merged
owlstronaut
pushed a commit
that referenced
this pull request
May 12, 2025
🤖 I have created a release *beep* *boop* --- ## [7.7.2](v7.7.1...v7.7.2) (2025-05-12) ### Bug Fixes * [`fcafb61`](fcafb61) [#780](#780) add missing `'use strict'` directives (#780) (@Fdawgs) * [`c99f336`](c99f336) [#781](#781) prerelease identifier starting with digits (#781) (@mbtools) ### Chores * [`c760403`](c760403) [#784](#784) template-oss-apply for workflow permissions (#784) (@wraithgar) * [`2677f2a`](2677f2a) [#778](#778) bump @npmcli/template-oss from 4.23.6 to 4.24.3 (#778) (@dependabot[bot], @npm-cli-bot) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #775
@wraithgar your suspicion was correct. The regex for the prerelease identifier was not precise enough. Changing the order of numeric and non-numeric parts fixes the issue. I reverted the change to
incfunction insemver.js. The tests still pass 😃I added tests that check the exact result of parsing valid versions in particular the pre-release and build parts which was somehow missing. We might want to add edge cases here.