Skip to content

Conversation

@chrros95
Copy link
Contributor

@chrros95 chrros95 commented Dec 5, 2025

This relates to...

Closes #4689

Rationale

With this pull request the custom connect behaviour of the H2CClient is replaced by the logic of the (h1) Client.

Changes

  • Replace parent class (DispatcherBase) of H2CClient with the Client
  • add useH2c parameter to Client and buildConnector to enable h2c on the socket

Features

n/a

Bug Fixes

  • request with socketPath parameter are now completed successfully.

Breaking Changes and Deprecations

n/a

Status

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.84%. Comparing base (5024d1b) to head (68edce2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4690   +/-   ##
=======================================
  Coverage   92.83%   92.84%           
=======================================
  Files         107      107           
  Lines       33515    33455   -60     
=======================================
- Hits        31115    31062   -53     
+ Misses       2400     2393    -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@metcoder95
Copy link
Member

Good work! I believe we can eventually get rid of the H2C client and embed it into the Client itself.

Errors are not related with the PR

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit e3fedb0 into nodejs:main Dec 6, 2025
33 of 35 checks passed
@chrros95 chrros95 deleted the h2c-with-uds branch December 6, 2025 12:15
@github-actions github-actions bot mentioned this pull request Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants