Skip to content

Conversation

@KhafraDev
Copy link
Member

fixes #4660

claude did ~half of this PR so be wary

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2025

Codecov Report

❌ Patch coverage is 94.21053% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.87%. Comparing base (7cc4fcf) to head (da5192a).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
lib/web/fetch/formdata-parser.js 94.21% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4662      +/-   ##
==========================================
- Coverage   92.87%   92.87%   -0.01%     
==========================================
  Files         106      106              
  Lines       33272    33354      +82     
==========================================
+ Hits        30902    30976      +74     
- Misses       2370     2378       +8     

☔ View full report in Codecov by Sentry.
��� Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@KhafraDev
Copy link
Member Author

Can we land this...? It's a bug fix. I don't know why I'm being asked to microoptimize everything.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit f29471c into nodejs:main Nov 9, 2025
34 of 35 checks passed
@KhafraDev
Copy link
Member Author

this seems to have fixed #4661 as well, great

@KhafraDev KhafraDev deleted the issue-4660 branch November 9, 2025 14:19
@github-actions github-actions bot mentioned this pull request Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants