feat(H2): correct CONNECT behaviour #4541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metcoder95
force-pushed
the
h2_connect
branch
from
14169a5 to
70a590d
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR corrects the CONNECT behavior for HTTP/2 connections by properly handling the response headers and status codes.
- Updates the CONNECT method handling to wait for the 'response' event before calling onUpgrade
- Passes the actual status code and parsed headers to the onUpgrade callback instead of null values
- Adds comprehensive test coverage for CONNECT functionality with a proxy server scenario
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/dispatcher/client-h2.js | Updated CONNECT method handling to properly process response headers and status codes |
| test/http2.js | Added comprehensive test for CONNECT functionality and updated existing test structure |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Uzlopak
approved these changes
Sep 12, 2025
Contributor
Uzlopak
left a comment
Uzlopak
left a comment
There was a problem hiding this comment.
RSLGTM
(because this is rn over my head :D)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to...
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status