Skip to content

Conversation

@Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Aug 26, 2025

fixes #3987

This is basically the same approach we use in @fastify/errors

This relates to...

Rationale

Changes

Features

Bug Fixes

Breaking Changes and Deprecations

Status

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

this should be backporrted to v6

@Uzlopak Uzlopak merged commit 5f256af into main Aug 27, 2025
36 checks passed
@Uzlopak Uzlopak deleted the fix-instance-of-undici-errors branch August 27, 2025 11:05
@github-actions
Copy link
Contributor

The backport to v6.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v6.x v6.x
# Navigate to the new working tree
cd .worktrees/backport-v6.x
# Create a new branch
git switch --create backport-4472-to-v6.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5f256afdcb49d0502bc61056ad49a829814b25cb
# Push it to GitHub
git push --set-upstream origin backport-4472-to-v6.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v6.x

Then, create a pull request where the base branch is v6.x and the compare/head branch is backport-4472-to-v6.x.

@metcoder95
Copy link
Member

@Uzlopak can you try to backport it?

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Aug 27, 2025

i will try to backport it. Currently doing some other stuff locally. ;)

Uzlopak added a commit that referenced this pull request Aug 27, 2025
* feat: make UndiciErrors reliable to instanceof

* also take MockNotMatchedError into account

(cherry picked from commit 5f256af)
Uzlopak added a commit that referenced this pull request Aug 27, 2025
* feat: make UndiciErrors reliable to instanceof

* also take MockNotMatchedError into account

(cherry picked from commit 5f256af)
@github-actions github-actions bot mentioned this pull request Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants