Skip to content

don't set a finalizer on cloned request #4320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
KhafraDev merged 2 commits into from
Jul 4, 2025
Merged

don't set a finalizer on cloned request #4320

KhafraDev merged 2 commits into from
Jul 4, 2025

Conversation

@tsctx
Copy link
Member

@tsctx tsctx commented Jul 4, 2025

Fixes #4150
mcollina
mcollina approved these changes Jul 4, 2025
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
@mcollina mcollina requested a review from KhafraDev July 4, 2025 15:22
@KhafraDev KhafraDev merged commit c5e7464 into main Jul 4, 2025
33 of 34 checks passed
@tsctx tsctx deleted the fix-4150 branch July 4, 2025 20:27
@github-actions github-actions bot mentioned this pull request Jul 18, 2025
Merged
snyamathi added a commit to snyamathi/undici that referenced this pull request Aug 15, 2025
@snyamathi
Revert "don't set a finalizer on cloned request (nodejs#4320)"
a7ae33a 
This reverts commit c5e7464.
@snyamathi snyamathi mentioned this pull request Aug 15, 2025
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@tsctx @mcollina @KhafraDev