Skip to content

Conversation

@styfle
Copy link
Member

@styfle styfle commented May 16, 2025

This relates to...

When I run pnpm install it creates a lockfile and I accidentally commit it.

Rationale

This doesn't happen when I run yarn install or npm install because they are already ignored. So we should also ignore pnpm lock file.

Changes

Add pnpm-lock.yaml to .gitignore

Features

N/A

Bug Fixes

N/A

Breaking Changes and Deprecations

N/A

Status

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@styfle
Copy link
Member Author

styfle commented May 16, 2025

@mcollina Looks like CI is failing for an unrelated reason

@mcollina mcollina merged commit d6deb77 into nodejs:main May 17, 2025
17 of 31 checks passed
@styfle styfle deleted the styfle/ignore-pnpm-lock branch May 18, 2025 18:07
@github-actions github-actions bot mentioned this pull request May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants