cache: more efficient sqlite indices #4142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
approved these changes
Apr 3, 2025
Member
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
lgtm
Should we bump the version?
Member
|
There are some failing wpts, which seems odd. |
Member
Author
I don't think that's necessary? |
Member
|
#4145 should cover for the failing tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop unnecessary single-column indices (url, method, start alone), as the composite index effectively covers them.
Avoid redundant indices that can slow down inserts without additional query benefits.