fix: cache: treat cache-control request header case-insensitively #4131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxndrsn
commented
Apr 2, 2025
metcoder95
approved these changes
Apr 23, 2025
gurgunday
approved these changes
Apr 23, 2025
alxndrsn
commented
Apr 23, 2025
dhalbrook
pushed a commit
to dhalbrook/undici
that referenced
this pull request
Apr 24, 2025
…dejs#4131) * fix: cache: treat cache-control request header case-insensitively Closes nodejs#3904 * lint; close server after test * call normaliseHeaders() once * revert unnecessary change --------- Co-authored-by: alxndrsn <alxndrsn>
dhalbrook
pushed a commit
to dhalbrook/undici
that referenced
this pull request
Apr 24, 2025
…vely (nodejs#4131)" This reverts commit 3d3c5cc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3904
This relates to...
Cache-Controlheader in request #3904Rationale
Changes
Features
N/A
Bug Fixes
Cache-Controlheader in request #3904Breaking Changes and Deprecations
N/A
Status