types(websocket): Import from stream/web #4038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metcoder95
reviewed
Feb 2, 2025
Member
metcoder95
left a comment
metcoder95
left a comment
There was a problem hiding this comment.
Can you add some test to it?
Jiralite
force-pushed
the
types/websocket-import
branch
from
c2f61cb to
003e3e5
Compare
Jiralite
force-pushed
the
types/websocket-import
branch
from
003e3e5 to
ecd828e
Compare
Jiralite
force-pushed
the
types/websocket-import
branch
from
ecd828e to
1e05453
Compare
KhafraDev
approved these changes
Apr 5, 2025
metcoder95
approved these changes
Apr 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to...
N/A
Rationale
ReadableStreamandWritableStreamwere not imported in the typings. This pull request imports them fromstream/web.Changes
Features
N/A
Bug Fixes
Fixes TypeScript compilation error:
https://github.com/discordjs/discord.js/actions/runs/13081715315/job/36506493876
Breaking Changes and Deprecations
N/A
Status