Skip to content

[15.x] Revert "stream: fix .end() error propagation" #37060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[15.x] Revert "stream: fix .end() error propagation" #37060

wants to merge 1 commit into from

Conversation

@mcollina
Copy link
Member

@mcollina mcollina commented Jan 25, 2021

This reverts commit 4c819d6.

Fixes #37027
@mcollina
Copy link
Member Author

mcollina commented Jan 25, 2021

cc @lpinca @danielleadams
@mcollina mcollina requested review from dnlup and ronag January 25, 2021 08:34
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 25, 2021 •
edited by BethGriggs
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/35722/ ✅
@Trott
Copy link
Member

Trott commented Jan 31, 2021

We should probably add a test for #37027. (Doesn't have to be here/now, though.)
@Trott
Copy link
Member

Trott commented Jan 31, 2021

Is the idea to land this again, but as a semver-major? Or to just leave it as it is?
@ronag
Copy link
Member

ronag commented Jan 31, 2021

Is the idea to land this again, but as a semver-major? Or to just leave it as it is?

Revert on 15 leave on master
@jasnell jasnell changed the title Revert "stream: fix .end() error propagation" Feb 1, 2021
@danielleadams
Copy link
Contributor

danielleadams commented Feb 15, 2021

Landed in d2a487e
danielleadams pushed a commit that referenced this pull request Feb 15, 2021
@mcollina @danielleadams
Revert "stream: fix .end() error propagation"
d2a487e 
This reverts commit 4c819d6.

PR-URL: #37060
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
@mcollina mcollina closed this Feb 15, 2021
This was referenced Feb 16, 2021
Closed
Merged
@lpinca lpinca mentioned this pull request Mar 5, 2021
Closed
@mcollina mcollina deleted the revert-36817-v15 branch March 5, 2021 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

8 participants

@mcollina @nodejs-github-bot @Trott @ronag @danielleadams @lpinca @BethGriggs @dnlup