Skip to content

refactor(push): make encryption/signing more robust #2619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
joshtrichards wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

refactor(push): make encryption/signing more robust #2619

joshtrichards wants to merge 7 commits into from

Conversation

@joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented Nov 1, 2025

This PR improves how push notification signing errors are handled to prevent sending unsigned notifications (which clients would reject anyway) and ensures clear, consistent error management.

  • Signing problems are consistently checked and logged cleanly.
  • Longer subjects are truncated to fit cryptographic limits, and truncation is now logged (debug level).
  • Unit tests have been added for the new error handling logic.
  • Code has been refactored for greater consistency and clarity.

Note:

  • Adds a PushSigningException for signing failures; affected devices are skipped, not deleted.
  • Device tokens are still only deleted for encryption failures (invalid device public key).
@joshtrichards
refactor(push): make encryption/signing more robust
ecc7ed6 
Improve error handling
Consistent logging
Refactoring for consistency

Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards
Add PushSigningException class for notifications
a173f17 
Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards
chore: fix namespace for PushSigningException
6323254 
Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards
fix: catch sig exception and skip device
db30703 
Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards
chore: make pushDeleteToDevice consistent with pushToDevice
23d3a62 
Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards
chore: tidy up
2bc74ae 
Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards
chore: Add tests for push to device signing errors
c6cf1a5 
Signed-off-by: Josh <josh.t.richards@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@joshtrichards