docs: Update JWT docs to reflect JWE changes in v4 #4313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nextauthjs/next-auth/DWVQEqJ8fkeBxsfJNVqj7Dxih5Vw |
ndom91
reviewed
Apr 4, 2022
Member
ndom91
left a comment
ndom91
left a comment
There was a problem hiding this comment.
Two small comments, but otherwise looks great! Thanks for the clean up!
Co-authored-by: Nico Domino <yo@ndo.dev>
Co-authored-by: Nico Domino <yo@ndo.dev>
Contributor
Author
|
Did them 👍 |
mnphpexpert
added a commit
to mnphpexpert/next-auth
that referenced
this pull request
Sep 2, 2024
* docs: Update JWT docs to reflect JWE changes in v4 This PR nextauthjs#3039 changed the defaults for JWT tokens to be encrypted by default (JWE). We have conflicting documentation across the docs site and readme. Additionatlly this PR nextauthjs#3783 made providing a secret required in production via NEXTAUTH_SECRET or an option. * Missed a reference * Update docs/docs/faq.md Co-authored-by: Nico Domino <yo@ndo.dev> * Update docs/docs/faq.md Co-authored-by: Nico Domino <yo@ndo.dev> Co-authored-by: Nico Domino <yo@ndo.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change language to be clear about JWT/JWE usage
Reasoning 💡
This PR #3039 changed the defaults for JWT tokens to be encrypted by default (JWE). We have conflicting documentation across the docs site and readme.
Additionatlly this PR #3783 made providing a secret required in production via NEXTAUTH_SECRET or an option.
The chagned sections were conflicting or clear with regards to current behavior.
Checklist 🧢
[ ] Tests