Repository navigation
Feature - add support for asynchronous filters - #289
Closed
davemaurakis wants to merge 1 commit into
Closed
davemaurakis wants to merge 1 commit into
davemaurakis wants to merge 1 commit into
Conversation
|
👍 |
|
@brownbathrobe Hi, brownbathrobe! I want to use your changes in pull request to implement height and width filter. Can you provide some example of filter usage or it can be used as usual? Thanks |
Author
|
@kuntsali - You should be able to use the filters as normal, but in the case of height/width you'll want the filter to return a promise. Here's an example that filters out folders: uploader.filters.push({
name: "rejectFolder",
fn: function (item) {
var deferred = $q.defer();
function accept () { deferred.resolve(); }
function reject () { deferred.reject(); }
if (uploader.isHTML5) {
var reader = new FileReader();
/* file can be read successfully */
reader.onloadstart = function () {
accept();
reader.onerror = null;
reader.abort();
};
/* file can not be read and is likely a folder */
reader.onerror = function () {
reject();
};
/* try to read the file item */
reader.readAsArrayBuffer(item);
} else {
accept();
}
return deferred.promise;
}
}); |
|
@brownbathrobe - Thank you! |
|
+1 |
Owner
|
Since The async filters require angular |
This was referenced Nov 29, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @nervgh
related to #235 & #180