Skip to content
This repository was archived by the owner on Apr 22, 2020. It is now read-only.

Parallelise batching of writes for similarity algorithms #814

Open
wants to merge 11 commits into
base: 3.4
Choose a base branch
from
Open

Parallelise batching of writes for similarity algorithms #814

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2777a82
batching wip
mneedham Feb 11, 2019
714545d
return write duration
mneedham Feb 11, 2019
e99384b
adding tests for similarity exporter
mneedham Feb 12, 2019
cd79fec
more tests
mneedham Feb 12, 2019
36ad67e
parameterise similarity test
mneedham Feb 12, 2019
f519abf
simplify the code for working out partitions
mneedham Feb 12, 2019
35cbc2b
remove duplication
mneedham Feb 12, 2019
c75886c
push more code into the base SimilarityExporter class
mneedham Feb 12, 2019
78ac242
remove spaces + tidy up imports
mneedham Feb 12, 2019
aed8535
package private some things
mneedham Feb 12, 2019
93691f7
writeMillis instead of writeDuration
mneedham Feb 12, 2019
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
package private some things
  • Loading branch information
@mneedham
mneedham committed Feb 12, 2019
commit aed8535aab9a26934f7ed1bea5c2d3a57640e755
6 changes: 3 additions & 3 deletions algo/src/main/java/org/neo4j/graphalgo/similarity/SimilarityExporter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@
public abstract class SimilarityExporter extends StatementApi {
final Log log;
final int propertyId;
final int relationshipTypeId;
private final int relationshipTypeId;

protected SimilarityExporter(GraphDatabaseAPI api, Log log, String propertyName, String relationshipType) {
SimilarityExporter(GraphDatabaseAPI api, Log log, String propertyName, String relationshipType) {
super(api);
this.log = log;
propertyId = getOrCreatePropertyId(propertyName);
Expand All @@ -58,7 +58,7 @@ private int getOrCreatePropertyId(String propertyName) {
.propertyKeyGetOrCreateForName(propertyName));
}

protected void createRelationship(SimilarityResult similarityResult, KernelTransaction statement) throws EntityNotFoundException, InvalidTransactionTypeKernelException, AutoIndexingKernelException {
private void createRelationship(SimilarityResult similarityResult, KernelTransaction statement) throws EntityNotFoundException, InvalidTransactionTypeKernelException, AutoIndexingKernelException {
long node1 = similarityResult.item1;
long node2 = similarityResult.item2;
long relationshipId = statement.dataWrite().relationshipCreate(node1, relationshipTypeId, node2);
Expand Down