Enhance checkConnection() function #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Define MESH_CONNECTION_CHECK_ATTEMPTS - Return from checkConnection() if -2 received, retry if -1, success if address matches, fail otherwise
2bndy5
requested changes
Jun 16, 2024
Member
2bndy5
left a comment
2bndy5
left a comment
There was a problem hiding this comment.
I don't think a return statement needs to be followed by a break statement in a switch block.
Co-authored-by: Brendan <2bndy5@gmail.com>
2bndy5
reviewed
Jun 16, 2024
2bndy5
approved these changes
Jun 16, 2024
2bndy5
added a commit
that referenced
this pull request
Jun 16, 2024
* Modify checkConnection() - Define MESH_CONNECTION_CHECK_ATTEMPTS - Return from checkConnection() if -2 received, retry if -1, success if address matches, fail otherwise * Update RF24Mesh_config.h Co-authored-by: Brendan <2bndy5@gmail.com> * Remove breaks; from switch - Per @2bndy5 in #240 * Update comment --------- Co-authored-by: Brendan <2bndy5@gmail.com>
Member
|
cherry-picked to v1.x |
Member
|
Did you want to try that new bump-n-release workflow? Or do you have some more pleasant surprises in store? |
Member
Author
|
I'm planning to do a little more coding over the next week or so, so lets see if I come up with anything else. This one I just came across while glancing at the code... |
2bndy5
added a commit
to nRF24/CircuitPython_nRF24L01
that referenced
this pull request
Jun 17, 2024
2bndy5
added a commit
to nRF24/CircuitPython_nRF24L01
that referenced
this pull request
Jan 29, 2025
* fix multicasting to level 2 and 4 * use all poll responses in mesh request_address() * reviewed RF24Messh._make_contacts() * use a set to avoid duplicates in list of poll responses * port changes to RF24Mesh.check_connection() per nRF24/RF24Mesh#240 * expose new release_address() for master nodes per nRF24/RF24Mesh#244 * improve scanner promiscuity similar to changes in nRF24/RF24#955 * update check_connection() per nRF24/RF24Mesh#250 * refactor network example for testing mesh connectivity * short circuit renew_address() when called from the master node * depend on spidev for linux arm 32 and 64 bit * abstract master code in check_connection() * don't use `check_connection()` in net example's `set_role()` * update RTD config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checkConnection() function:
checkConnection()if -2 received (not in list or default address)This should enhance stability a bit by raising the connection check attempts to 3.
It should also enhance the actual connection check by returning immediately and not retrying if a -2 is received (not in list or default address).
Furthermore it actually verifies that the returned RF24Network address matches the existing RF24Network address.