make utilities/CMakeLists.txt respect RF24_NO_IRQ #859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to update the pyRF24 pkg to use latest master. This does not affect RF24 lib builds because RF24_NO_IRQ is respected in the root CMakeLists.txt. But, the pyRF24 pkg doesn't actually use the root CMakeLists.txt. Instead, the pyRF24 pkg only uses utility/CMakeLists.txt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to update the pyRF24 pkg to use latest master.
This should not negatively affect RF24 lib builds because RF24_NO_INTERRUPT is respected in the root CMakeLists.txt. But, the pyRF24 pkg doesn't actually use the root CMakeLists.txt. Instead, the pyRF24 pkg only uses utility/CMakeLists.txt to get the appropriate driver sources/includes/etc.
This is the CMake equivalent of #839 which did the same exclusion of interrupt.h when it wasn't needed.