fix: Bug: listing models needs to filter out GGUF extension #7791
+13
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add .gguf to the list of file extensions to skip when listing models in the model path. This prevents raw GGUF model files from appearing as available models in the /v1/models endpoint. Fixes mudler#1077 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: majiayu000 <1835304752@qq.com>
✅ Deploy Preview for localai ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Owner
|
mmm this is on purpose actually, if a gguf model file is found in the model directory, you should be still able to use it without a config file, as LocalAI should use sane defaults in that case. This allows the user to manually drop gguf files in the model folder and that should just make it available in the API. Is there a specific issue you are trying to fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #1077
Changes
.ggufto theknownModelsNameSuffixToSkiplist inpkg/model/loader.goto filter out GGUF files from the model listing endpoint.gguffiles are properly filtered from the model listingTesting
.gguffiles are excluded fromListFilesInModelPath()🤖 Generated with Claude Code