fix: Highly inconsistent agent response to LocalAGI agent calling MCP server - Body "Invalid http method" #7790
+6
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes mudler#7772 The issue was caused by duplicate registration of the MCP endpoint /mcp/v1/chat/completions in both openai.go and localai.go, leading to a race condition where requests would randomly hit different handlers with incompatible behaviors. Changes: - Removed duplicate MCP route registration from openai.go - Kept the localai.MCPStreamEndpoint as the canonical handler - Added all three MCP route patterns for backward compatibility: * /v1/mcp/chat/completions * /mcp/v1/chat/completions * /mcp/chat/completions - Added comments to clarify route ownership and prevent future conflicts - Fixed formatting in ui_api.go The localai.MCPStreamEndpoint handler is more feature-complete as it supports both streaming and non-streaming modes, while the removed openai.MCPCompletionEndpoint only supported synchronous requests. This eliminates the ~50% failure rate where the cogito library would receive "Invalid http method" errors when internal HTTP requests were routed to the wrong handler. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: majiayu000 <1835304752@qq.com>
✅ Deploy Preview for localai ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mudler
reviewed
Dec 30, 2025
| }, | ||
| } | ||
| app.POST("/mcp/v1/chat/completions", mcpCompletionHandler, mcpCompletionMiddleware...) | ||
| app.POST("/mcp/chat/completions", mcpCompletionHandler, mcpCompletionMiddleware...) |
Owner
There was a problem hiding this comment.
ouch! good catch here.
mcp/v1/chat/completions is duplicated, but the rationale here is that the streaming mode supported in MCPStreamEndpoint breaks OpenAI compatibility and it's LocalAI-specific as it emits a different messaging exchange format.
I'm ok with dropping it here in favor to move to the implementation in localai.go, but we should cleanup the unused function now MCPCompletionEndpoint, and rename MCPStreamEndpoint as it is misleading, maybe it can just be MCPEndpoint as it works both streaming and non-streaming mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #7772
Problem
The issue was caused by duplicate registration of the MCP endpoint
/mcp/v1/chat/completionsin bothopenai.goandlocalai.go. This led to a race condition where approximately 50% of requests would randomly hit different handlers with incompatible behaviors, resulting in "Invalid http method" errors.Changes
Removed duplicate MCP route registration from openai.go
MCPCompletionEndpointhandler and its associated middlewareConsolidated to single canonical handler in localai.go
localai.MCPStreamEndpointas the canonical handleropenai.MCPCompletionEndpointonly supported synchronous requestsAdded all three MCP route patterns for backward compatibility
/v1/mcp/chat/completions- Primary pattern/mcp/v1/chat/completions- Alternate ordering/mcp/chat/completions- Legacy pattern for backward compatibilityDocumentation and maintenance improvements
Testing
go fmtImpact
This eliminates the ~50% failure rate where the cogito library would receive "Invalid http method" errors when internal HTTP requests were randomly routed to the wrong handler.
Generated with Claude Code