Remove SphericalReflectionMapping #19517
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here, sphere maps are camera view-dependent and are not appropriate as we are using them. Furthermore, SEMs assume the object is centered directly in front of the camera, which is generally not the case in three.js.
Users can use
MeshMatcapMaterialinstead. I have seen users useSphericalReflectionMapping, but they are passing in a matcap texture, thinking it is the same thing. A spherical reflection map is not the same as a matcap.//
@mrdoob I am not sure about the change I made to
Sidebar.Material.js...@takahirox I was also not sure what to do with
MMDLoader.js.MeshToonMaterialno longer extendsMeshPhongMaterial(#18003), and no longer supports environment maps, so I was not sure what changes would be appropriate toMMDLoader.js. That loader is not modified in this PR. Can you please have a look? We can safely save it for later.To do: update migration docs when appropriate.