Repository navigation
Bug 2073093 - Migrate the listExtensions tool to use webExtension.moz:listExtensions - #215
Merged
juliandescottes merged 1 commit intoOct 29, 2026
Conversation
juliandescottes
requested changes
Oct 22, 2026
juliandescottes
left a comment
juliandescottes
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for following up here @f3tchcodes ! See comments, a few things to update, but most importantly would like to see an integration test here.
f3tchcodes
force-pushed
the
bug-2073093-webExtension-moz-listExtensions
branch
from
October 27, 2026 18:26
dea2f95 to
a8fb080
Compare
Contributor
Author
|
I've made all the changes and added the integration test, also I decided to keep the unit test as well. I ran the integration tests and they all pass on my machine. Could you please review now? |
f3tchcodes
force-pushed
the
bug-2073093-webExtension-moz-listExtensions
branch
from
October 27, 2026 18:33
a8fb080 to
173fd2b
Compare
Contributor
Author
|
Looks like there were some conflicts, I've just rebased and resolved them. Should be ready to review and merge if everything's been implemented correctly. |
f3tchcodes
force-pushed
the
bug-2073093-webExtension-moz-listExtensions
branch
from
October 27, 2026 18:51
173fd2b to
9556919
Compare
Contributor
Author
|
Forgot to update a few things, done* |
Collaborator
|
Thanks for the update, taking a look today! |
juliandescottes
requested changes
Oct 28, 2026
juliandescottes
left a comment
juliandescottes
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the update, a few additional things to check here.
f3tchcodes
force-pushed
the
bug-2073093-webExtension-moz-listExtensions
branch
from
October 29, 2026 16:25
9556919 to
68f7445
Compare
juliandescottes
requested changes
Oct 29, 2026
f3tchcodes
force-pushed
the
bug-2073093-webExtension-moz-listExtensions
branch
from
October 29, 2026 20:59
68f7445 to
3297ab1
Compare
juliandescottes
approved these changes
Oct 29, 2026
juliandescottes
left a comment
juliandescottes
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @f3tchcodes !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: 2073093
Switching from chrome privileged scripts to
webExtension.moz:listExtensionsfor listing extensions.