Skip to content

feat: add breadcrumbs to folder setting #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hezhizhen wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add breadcrumbs to folder setting #296

hezhizhen wants to merge 1 commit into from
+42 −2

Conversation

@hezhizhen
Copy link
Contributor

@hezhizhen hezhizhen commented Nov 12, 2025

Preview:

image
stasyu2009-ux

This comment was marked as spam.

Sign in to view

@stasyu2009-ux

This comment was marked as spam.

Sign in to view
@stasyu2009-ux

This comment was marked as spam.

Sign in to view
stasyu2009-ux

This comment was marked as spam.

Sign in to view

@hezhizhen hezhizhen force-pushed the add-breadcrumbs-in-folder-settings branch 2 times, most recently from ea06b7b to 7a30132 Compare December 6, 2025 06:14
@hezhizhen
Copy link
Contributor Author

hezhizhen commented Dec 12, 2025

@gschier any ideas?
@hezhizhen hezhizhen force-pushed the add-breadcrumbs-in-folder-settings branch from 7a30132 to 98210b0 Compare December 12, 2025 06:31
@hezhizhen hezhizhen force-pushed the add-breadcrumbs-in-folder-settings branch from 98210b0 to 8afb35e Compare December 12, 2025 06:45
@gschier
Copy link
Member

gschier commented Dec 12, 2025

@hezhizhen I'm okay with this but I'm not crazy about the visual design (looks too much like an input field). I don't have any ideas to make it better, but two things to try:

  • Adjust the current styling to make it look more like traditional breadcrumbs (maybe just remove the border and label? I'm not sure what would look best)
  • Put the breadcrumbs in the dialog title instead
@hezhizhen
Copy link
Contributor Author

hezhizhen commented Dec 14, 2025

@hezhizhen I'm okay with this but I'm not crazy about the visual design (looks too much like an input field). I don't have any ideas to make it better, but two things to try:

  • Adjust the current styling to make it look more like traditional breadcrumbs (maybe just remove the border and label? I'm not sure what would look best)
  • Put the breadcrumbs in the dialog title instead

I see. I'll update this PR and screenshots based on your suggestion later when I have enough free time to work on it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@hezhizhen @stasyu2009-ux @gschier