Skip to content

Conversation

@gribnoysup
Copy link
Collaborator

Should be pass the tests and compile, draft until I open a ticket and update the TODO comment. I have a codemod to follow-up with conversion pretty quickly, just didn't want to make this PR harder to review

@gribnoysup gribnoysup added the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label Nov 26, 2025
@nbbeeken
Copy link
Collaborator

I was thinking about this when I commented about the enums here would be really cool to get this, love me some erasableSyntaxOnly typescript 💙 (takin a look 👁️)

Copy link
Collaborator

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well that wasn't a difficult review. I assume the draft is cus we're waiting to see fall out from CI to see if anything was missed?

I think I remember the docs recommend combining this with verbatimModuleSyntax but I imagine that is out of reach if we have specific dependence on automatic conversion to require or would cause a bunch more changes with import type enforcement.

@gribnoysup
Copy link
Collaborator Author

We already enforce import type for type imports via eslint (it bit us before a couple of times), but the autoconversion might be an issue yeah. I haven't heard about this one though, so worth trying as a follow-up

Main reason this is a draft is to not forget to stick a TODO ticket for enums so that we don't lose track of the enum conversion even if it should follow quickly 🙂

@gribnoysup gribnoysup marked this pull request as ready for review December 1, 2025 13:14
@gribnoysup gribnoysup requested a review from a team as a code owner December 1, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)

3 participants