Skip to content

Conversation

@Feng0w0
Copy link

@Feng0w0 Feng0w0 commented Dec 30, 2025

Add NPU environment installation steps in Setup.md. Add optional npu and npu_aarch64 in the pyproject.toml file.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Feng0w0, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the clarity and completeness of the NPU environment installation guide. It introduces a structured approach for setting up the Ascend NPU environment, including prerequisites and architecture-specific installation commands, and integrates these requirements into the project's dependency management. The changes aim to provide a smoother and more reliable setup experience for users leveraging NPU hardware.

Highlights

  • Updated NPU Installation Documentation: The documentation for Ascend NPU environment setup in both English and Chinese (docs/en/Pipeline_Usage/Setup.md and docs/zh/Pipeline_Usage/Setup.md) has been significantly revised. It now guides users through installing CANN and then installing the project from source using specific optional dependencies for NPU.
  • New Optional Dependencies for NPU: The pyproject.toml file has been updated to include new optional dependency groups: npu_aarch64 and npu. These groups specify the required versions of torch, torch-npu, and torchvision for different NPU architectures (aarch64/ARM and x86 respectively).
  • Streamlined NPU Setup: The previous direct pip install torch-npu command has been replaced with a more comprehensive source-based installation method, ensuring a more robust and architecture-specific setup for Ascend NPU users.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation to include installation instructions for Ascend NPU environments and adds the corresponding optional dependencies to pyproject.toml. The changes are a good addition, making it easier for users with NPUs to set up the project. I've found a couple of areas for improvement: the English documentation for NPU setup links to a Chinese document, and there's a potential issue with the package versions for npu_aarch64 dependencies.

Comment on lines +39 to +41
"torch==2.7.1",
"torch-npu==2.7.1",
"torchvision==0.22.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The torch and torchvision packages for npu_aarch64 should specify the CPU-only versions by adding the +cpu suffix, similar to the npu (x86) dependencies. The installation command in Setup.md for aarch64 points to the CPU wheel index, which contains packages with this suffix (e.g., torch==2.7.1+cpu). Without the suffix, pip might fail to find the correct package or install a version from another index that is not compatible.

Suggested change
"torch==2.7.1",
"torch-npu==2.7.1",
"torchvision==0.22.1"
"torch==2.7.1+cpu",
"torch-npu==2.7.1",
"torchvision==0.22.1+cpu"
```shell
pip install torch-npu==2.1.0.post17
```
1. Install [CANN](https://www.hiascend.com/document/detail/zh/canncommercial/83RC1/softwareinst/instg/instg_quick.html?Mode=PmIns&InstallType=local&OS=openEuler&Software=cannToolKit) through official documentation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The link to the CANN installation documentation points to a Chinese version of the page. Since this is the English documentation, it would be better to link to the English version for a better user experience.

Suggested change
1. Install [CANN](https://www.hiascend.com/document/detail/zh/canncommercial/83RC1/softwareinst/instg/instg_quick.html?Mode=PmIns&InstallType=local&OS=openEuler&Software=cannToolKit) through official documentation.
1. Install [CANN](https://www.hiascend.com/document/detail/en/canncommercial/83RC1/softwareinst/instg/instg_quick.html) through official documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant